Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x][Multiple Datasource] Support Amazon OpenSearch Serverless (#3957) #4066

Merged
merged 1 commit into from
May 22, 2023
Merged

[Backport 2.x][Multiple Datasource] Support Amazon OpenSearch Serverless (#3957) #4066

merged 1 commit into from
May 22, 2023

Conversation

zhongnansu
Copy link
Member

Backport (e737790) from #3957

@zhongnansu
[Multiple Datasource] Support Amazon OpenSearch Serverless (opensearc…
8575b92 
…h-project#3957)

* [Multiple Datasource]Support Amazon OpenSearch Serverless in SigV4
* remove experimental text in yml
* Refactor create data source form for authentication

Signed-off-by: Su <[email protected]>
(cherry picked from commit e737790)
@zhongnansu zhongnansu added multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.8.0 labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Merging #4066 (8575b92) into 2.x (e455e48) will increase coverage by 0.01%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##              2.x    #4066      +/-   ##
==========================================
+ Coverage   66.44%   66.45%   +0.01%     
==========================================
  Files        3229     3229              
  Lines       62045    62064      +19     
  Branches     9596     9602       +6     
==========================================
+ Hits        41225    41246      +21     
+ Misses      18518    18514       -4     
- Partials     2302     2304       +2
Flag Coverage Δ
Linux 66.39% <55.55%> (+0.01%) ⬆️
Windows 66.40% <55.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s_credential_modal/update_aws_credential_modal.tsx 5.00% <0.00%> (-0.27%) ⬇️
...omponents/validation/datasource_form_validation.ts 70.96% <0.00%> (-4.90%) ⬇️
...rce/components/edit_form/edit_data_source_form.tsx 66.66% <30.76%> (-1.03%) ⬇️
...components/create_form/create_data_source_form.tsx 74.00% <73.33%> (-1.00%) ⬇️
...gins/data_source/server/client/configure_client.ts 71.42% <100.00%> (ø)
...ata_source/server/client/configure_client_utils.ts 86.11% <100.00%> (ø)
...ta_source/server/legacy/configure_legacy_client.ts 71.15% <100.00%> (+11.53%) ⬆️
...e_data_source_wizard/create_data_source_wizard.tsx 97.56% <100.00%> (+0.06%) ⬆️
src/plugins/data_source_management/public/types.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@zhongnansu
Copy link
Member Author

@zengyan-amazon Can I get approval from you?

@zhongnansu zhongnansu merged commit 1c09ca6 into opensearch-project:2.x May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengyan-amazon zengyan-amazon zengyan-amazon approved these changes

@kristenTian kristenTian kristenTian approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

Assignees

@zengyan-amazon zengyan-amazon

@kristenTian kristenTian

Labels
multiple datasource multiple datasource project Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongnansu @zengyan-amazon @kristenTian